Add fsnotify to watch files in the gke-pod-network directory #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign mrhohn |
sypakine
reviewed
Apr 13, 2022
sypakine
reviewed
Apr 13, 2022
sypakine
reviewed
Apr 13, 2022
sypakine
reviewed
Apr 13, 2022
sypakine
reviewed
Apr 13, 2022
sypakine
approved these changes
Apr 13, 2022
By doing this, we will not parse the entire gke-pod-network directory every 30 seconds. Instead, we will only parse the directory every time there is a change in the pod IP allocation. For most cases, this will be more efficient.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdmodi, sypakine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyuanliang
added a commit
to jingyuanliang/netd
that referenced
this pull request
Sep 4, 2024
… 1.23] Also bump base image to distroless-iptables:v0.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this, we will not parse the entire gke-pod-network directory every 30 seconds. Instead, we will only parse the directory every time there is a change in the pod IP allocation. For most cases, this will be more efficient.