-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass CILIUM_FAST_START_NAMESPACES env var over into cilium-cni #277
Conversation
@jingyuanliang: GitHub didn't allow me to assign the following users: pravk03. Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pravk03 |
@jingyuanliang: GitHub didn't allow me to assign the following users: pravk03. Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pravk03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shell script logic seems good to me but don't have the full context on fast start namespace - will wait for Praveen to review as well.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyuanliang, pravk03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
578be24
into
GoogleCloudPlatform:master
…nup_env in test
Fix #277: add CILIUM_FAST_START_NAMESPACES to cleanup_env in test
…2-fast-start-namespaces
Followup #277: add dpv2- prefix to fast-start-namespaces
/assign @MrHohn
/assign @pravk03
/hold