Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CILIUM_FAST_START_NAMESPACES env var over into cilium-cni #277

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

jingyuanliang
Copy link
Member

/assign @MrHohn
/assign @pravk03
/hold

Copy link
Contributor

@jingyuanliang: GitHub didn't allow me to assign the following users: pravk03.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @MrHohn
/assign @pravk03
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingyuanliang
Copy link
Member Author

/assign @pravk03

Copy link
Contributor

@jingyuanliang: GitHub didn't allow me to assign the following users: pravk03.

Note that only GoogleCloudPlatform members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @pravk03

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingyuanliang
Copy link
Member Author

/assign @pravk03

Copy link
Collaborator

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell script logic seems good to me but don't have the full context on fast start namespace - will wait for Praveen to review as well.

@google-oss-prow google-oss-prow bot added the lgtm label Feb 26, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, pravk03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyuanliang
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 578be24 into GoogleCloudPlatform:master Feb 27, 2024
5 checks passed
jingyuanliang added a commit to jingyuanliang/netd that referenced this pull request Feb 27, 2024
google-oss-prow bot added a commit that referenced this pull request Feb 27, 2024
Fix #277: add CILIUM_FAST_START_NAMESPACES to cleanup_env in test
jingyuanliang added a commit to jingyuanliang/netd that referenced this pull request Mar 6, 2024
jingyuanliang added a commit to jingyuanliang/netd that referenced this pull request Mar 6, 2024
jingyuanliang added a commit to jingyuanliang/netd that referenced this pull request Mar 7, 2024
google-oss-prow bot added a commit that referenced this pull request Mar 7, 2024
Followup #277: add dpv2- prefix to fast-start-namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants