Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor cloudsql_postgresql test #1700

Closed
wants to merge 55 commits into from
Closed

chore: refactor cloudsql_postgresql test #1700

wants to merge 55 commits into from

Conversation

sofisl
Copy link
Collaborator

@sofisl sofisl commented Apr 1, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@sofisl sofisl requested a review from fhinkel April 16, 2020 21:09
@sofisl sofisl marked this pull request as ready for review April 16, 2020 21:36
@sofisl sofisl requested a review from michaelawyu as a code owner April 16, 2020 21:36
sofisl and others added 2 commits April 16, 2020 14:38
@sofisl
fix dependencies
7c3b6cc
@renovate-bot
chore(deps): update dependency puppeteer to v3 (GoogleCloudPlatform#1719
ad7a245 
)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [puppeteer](https://togithub.com/puppeteer/puppeteer) | devDependencies | major | [`^2.0.0` -> `^3.0.0`](https://renovatebot.com/diffs/npm/puppeteer/2.1.1/3.0.0) |

---

### Release Notes

<details>
<summary>puppeteer/puppeteer</summary>

### [`v3.0.0`](https://togithub.com/puppeteer/puppeteer/releases/v3.0.0)

[Compare Source](https://togithub.com/puppeteer/puppeteer/compare/v2.1.1...v3.0.0)

#### Big changes

-   Chromium 81.0.4044.0 (r737027)
-   Puppeteer can now fetch a Firefox Nightly binary for you via `PUPPETEER_PRODUCT=firefox npm install`. Also, there’s now [an example](https://togithub.com/puppeteer/puppeteer/blob/master/examples/cross-browser.js) showing how to launch Firefox with Puppeteer.
-   File uploads are generally more reliable ([#&#8203;5363](https://togithub.com/puppeteer/puppeteer/issues/5363)) and `elementHandle.uploadFile(...filePaths)` now triggers a `change` event, matching the old behavior in Puppeteer v1.20.0. ([#&#8203;5389](https://togithub.com/puppeteer/puppeteer/issues/5389))
-   Node.js v8.x.x is no longer supported. ([#&#8203;5136](https://togithub.com/puppeteer/puppeteer/issues/5136))

#### Behind the scenes

-   Puppeteer is migrating to TypeScript. Although this doesn't affect the way developers can consume Puppeteer, it improves the quality of the Puppeteer type definitions which can be used by modern editors.
-   Our custom test runner framework has been removed in favor of Mocha, reducing maintenance overhead.
-   Our CI setup and the way we deal with test flakiness is being reworked in order to increase our confidence of landing PRs without breaking anything.

#### Raw notes

[`6760b92`](https://togithub.com/puppeteer/puppeteer/commit/6760b92) - chore: mark version v3.0.0 ([#&#8203;5642](https://togithub.com/puppeteer/puppeteer/issues/5642))
[`3387aab`](https://togithub.com/puppeteer/puppeteer/commit/3387aab) - feat(chromium): roll Chromium to r737027 ([#&#8203;5644](https://togithub.com/puppeteer/puppeteer/issues/5644))
[`c5df490`](https://togithub.com/puppeteer/puppeteer/commit/c5df490) - docs(readme): update cross-browser FAQ ([#&#8203;5634](https://togithub.com/puppeteer/puppeteer/issues/5634))
[`35989a7`](https://togithub.com/puppeteer/puppeteer/commit/35989a7) - fix: set revision based on PUPPETEER_PRODUCT ([#&#8203;5643](https://togithub.com/puppeteer/puppeteer/issues/5643))
[`d817ae5`](https://togithub.com/puppeteer/puppeteer/commit/d817ae5) - fix: update preferred revision after Launcher is created ([#&#8203;5640](https://togithub.com/puppeteer/puppeteer/issues/5640))
[`df81250`](https://togithub.com/puppeteer/puppeteer/commit/df81250) - chore: update ws library ([#&#8203;5638](https://togithub.com/puppeteer/puppeteer/issues/5638))
[`2529ee6`](https://togithub.com/puppeteer/puppeteer/commit/2529ee6) - chore(eslint): add eslint typescript linting ([#&#8203;5635](https://togithub.com/puppeteer/puppeteer/issues/5635))
[`88d843d`](https://togithub.com/puppeteer/puppeteer/commit/88d843d) - feat(TypeScript): move DeviceDescriptors to TS ([#&#8203;5595](https://togithub.com/puppeteer/puppeteer/issues/5595))
[`1ce4fe7`](https://togithub.com/puppeteer/puppeteer/commit/1ce4fe7) - chore(deps): update extract-zip to version 2 ([#&#8203;5610](https://togithub.com/puppeteer/puppeteer/issues/5610))
[`0bcc5a7`](https://togithub.com/puppeteer/puppeteer/commit/0bcc5a7) - chore: migrate remaining tests to Mocha ([#&#8203;5616](https://togithub.com/puppeteer/puppeteer/issues/5616))
[`17cd870`](https://togithub.com/puppeteer/puppeteer/commit/17cd870) - chore: migrate unit tests to Mocha ([#&#8203;5600](https://togithub.com/puppeteer/puppeteer/issues/5600))
[`262da92`](https://togithub.com/puppeteer/puppeteer/commit/262da92) - chore(test): re-enable Firefox testing on CI ([#&#8203;5608](https://togithub.com/puppeteer/puppeteer/issues/5608))
[`83d9d53`](https://togithub.com/puppeteer/puppeteer/commit/83d9d53) - chore: update CI to run Travis + Linux + Chromium ([#&#8203;5583](https://togithub.com/puppeteer/puppeteer/issues/5583))
[`21c2d31`](https://togithub.com/puppeteer/puppeteer/commit/21c2d31) - docs(api): update another emulateMediaType example ([#&#8203;5607](https://togithub.com/puppeteer/puppeteer/issues/5607))
[`fefa8ca`](https://togithub.com/puppeteer/puppeteer/commit/fefa8ca) - docs(api): update emulateMediaType example ([#&#8203;5606](https://togithub.com/puppeteer/puppeteer/issues/5606))
[`bbdaf92`](https://togithub.com/puppeteer/puppeteer/commit/bbdaf92) - docs(README): remove unused badges
[`efe561e`](https://togithub.com/puppeteer/puppeteer/commit/efe561e) - chore: fix DocLint method diffing ([#&#8203;5594](https://togithub.com/puppeteer/puppeteer/issues/5594))
[`841c2a5`](https://togithub.com/puppeteer/puppeteer/commit/841c2a5) - chore: fix emulateMedia tests ([#&#8203;5593](https://togithub.com/puppeteer/puppeteer/issues/5593))
[`8fa034b`](https://togithub.com/puppeteer/puppeteer/commit/8fa034b) - chore: remove flakiness dashboard ([#&#8203;5592](https://togithub.com/puppeteer/puppeteer/issues/5592))
[`4ee2c43`](https://togithub.com/puppeteer/puppeteer/commit/4ee2c43) - chore: fix Page.emulateMedia doclint failure ([#&#8203;5584](https://togithub.com/puppeteer/puppeteer/issues/5584))
[`a99a3cf`](https://togithub.com/puppeteer/puppeteer/commit/a99a3cf) - chore: skip failing cookie tests in Firefox ([#&#8203;5575](https://togithub.com/puppeteer/puppeteer/issues/5575))
[`88446df`](https://togithub.com/puppeteer/puppeteer/commit/88446df) - chore: fix missed `src/` vs `lib/` documentation ([#&#8203;5591](https://togithub.com/puppeteer/puppeteer/issues/5591))
[`b3b0dc5`](https://togithub.com/puppeteer/puppeteer/commit/b3b0dc5) - docs: replace invalid device descriptors link ([#&#8203;5589](https://togithub.com/puppeteer/puppeteer/issues/5589))
[`99ecdba`](https://togithub.com/puppeteer/puppeteer/commit/99ecdba) - docs: fix simple typo ([#&#8203;5585](https://togithub.com/puppeteer/puppeteer/issues/5585))
[`7f7887e`](https://togithub.com/puppeteer/puppeteer/commit/7f7887e) - docs(puppeteer-firefox): add deprecation warning to README ([#&#8203;5502](https://togithub.com/puppeteer/puppeteer/issues/5502))
[`6522e4f`](https://togithub.com/puppeteer/puppeteer/commit/6522e4f) - chore: Use expect for assertions ([#&#8203;5581](https://togithub.com/puppeteer/puppeteer/issues/5581))
[`4c41421`](https://togithub.com/puppeteer/puppeteer/commit/4c41421) - chore: run Chromium on Node.js 12 on Travis ([#&#8203;5582](https://togithub.com/puppeteer/puppeteer/issues/5582))
[`f434684`](https://togithub.com/puppeteer/puppeteer/commit/f434684) - chore: fix link to source files in documentation ([#&#8203;5576](https://togithub.com/puppeteer/puppeteer/issues/5576))
[`2b52b86`](https://togithub.com/puppeteer/puppeteer/commit/2b52b86) - chore: remove travis-autodeploy ([#&#8203;5580](https://togithub.com/puppeteer/puppeteer/issues/5580))
[`7a2a41f`](https://togithub.com/puppeteer/puppeteer/commit/7a2a41f) - chore: move code to src/ and emit with TypeScript ([#&#8203;5568](https://togithub.com/puppeteer/puppeteer/issues/5568))
[`c82b556`](https://togithub.com/puppeteer/puppeteer/commit/c82b556) - docs: connect works with any supported browser ([#&#8203;5572](https://togithub.com/puppeteer/puppeteer/issues/5572))
[`d678013`](https://togithub.com/puppeteer/puppeteer/commit/d678013) - chore: upgrade TypeScript to 3.8 ([#&#8203;5566](https://togithub.com/puppeteer/puppeteer/issues/5566))
[`3dff24a`](https://togithub.com/puppeteer/puppeteer/commit/3dff24a) - chore: upgrade eslint to v6.8.0 ([#&#8203;5563](https://togithub.com/puppeteer/puppeteer/issues/5563))
[`4b0fd8b`](https://togithub.com/puppeteer/puppeteer/commit/4b0fd8b) - chore: upgrade to TypeScript 3.7 ([#&#8203;5562](https://togithub.com/puppeteer/puppeteer/issues/5562))
[`29b626a`](https://togithub.com/puppeteer/puppeteer/commit/29b626a) - chore: upgrade TypeScript to 3.6 ([#&#8203;5559](https://togithub.com/puppeteer/puppeteer/issues/5559))
[`5e8d79b`](https://togithub.com/puppeteer/puppeteer/commit/5e8d79b) - chore: upgrade to TypeScript 3.5 ([#&#8203;5556](https://togithub.com/puppeteer/puppeteer/issues/5556))
[`b9240b1`](https://togithub.com/puppeteer/puppeteer/commit/b9240b1) - chore: bump rimraf to v3.0.2 ([#&#8203;5431](https://togithub.com/puppeteer/puppeteer/issues/5431))
[`067662c`](https://togithub.com/puppeteer/puppeteer/commit/067662c) - Emit change event on uploadFile calls ([#&#8203;5389](https://togithub.com/puppeteer/puppeteer/issues/5389))
[`a3d1536`](https://togithub.com/puppeteer/puppeteer/commit/a3d1536) - Bugfix: Docker build failure ([#&#8203;5400](https://togithub.com/puppeteer/puppeteer/issues/5400))
[`33f1967`](https://togithub.com/puppeteer/puppeteer/commit/33f1967) - (feat) Add option to fetch Firefox Nightly ([#&#8203;5467](https://togithub.com/puppeteer/puppeteer/issues/5467))
[`807fbbd`](https://togithub.com/puppeteer/puppeteer/commit/807fbbd) - chore: drop Node.js v8 support ([#&#8203;5365](https://togithub.com/puppeteer/puppeteer/issues/5365))
[`0b1a9ce`](https://togithub.com/puppeteer/puppeteer/commit/0b1a9ce) - chore: Replace Juggler with Firefox Nightly in CI ([#&#8203;5395](https://togithub.com/puppeteer/puppeteer/issues/5395))
[`0b1777e`](https://togithub.com/puppeteer/puppeteer/commit/0b1777e) - docs(api) Fix url ([#&#8203;5367](https://togithub.com/puppeteer/puppeteer/issues/5367))
[`5ffcde2`](https://togithub.com/puppeteer/puppeteer/commit/5ffcde2) - chore: bump version to v2.1.1.-post ([#&#8203;5390](https://togithub.com/puppeteer/puppeteer/issues/5390))
[`46386eb`](https://togithub.com/puppeteer/puppeteer/commit/46386eb) - chore: mark version v2.1.1 ([#&#8203;5388](https://togithub.com/puppeteer/puppeteer/issues/5388))
[`9923e56`](https://togithub.com/puppeteer/puppeteer/commit/9923e56) - fix(filechooser): quick fix for the headful file chooser ([#&#8203;5369](https://togithub.com/puppeteer/puppeteer/issues/5369))
[`1a1ef83`](https://togithub.com/puppeteer/puppeteer/commit/1a1ef83) - Add FAQ entry on cross-browser support ([#&#8203;5360](https://togithub.com/puppeteer/puppeteer/issues/5360))
[`0d243b7`](https://togithub.com/puppeteer/puppeteer/commit/0d243b7) - feat: make it possible to run `install.js` script with `puppeteer-core` ([#&#8203;5325](https://togithub.com/puppeteer/puppeteer/issues/5325))
[`c283fea`](https://togithub.com/puppeteer/puppeteer/commit/c283fea) - docs(api): add example to page.$$eval ([#&#8203;5200](https://togithub.com/puppeteer/puppeteer/issues/5200))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/nodejs-docs-samples).
fhinkel
fhinkel requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete repo-tools that example?

@sofisl sofisl requested a review from noerog as a code owner April 16, 2020 22:56
@sofisl sofisl closed this Apr 16, 2020
This was referenced Jun 20, 2023
Open
Open
Open
Open
Open
Open
Open
@pedroarapua pedroarapua mentioned this pull request Jul 6, 2023
Open
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Jul 6, 2023
Merged
@aqualen aqualen mentioned this pull request Jul 7, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel requested changes

@michaelawyu michaelawyu Awaiting requested review from michaelawyu

@noerog noerog Awaiting requested review from noerog

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sofisl @fhinkel @googlebot @renovate-bot @noerog