-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate code from googleapis/nodejs-game-servers #2820
Closed
Closed
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
027e386
Initial client library creation
telpirion af278cd
feat: updates package.json files and quickstart
telpirion 8caa892
Adds quickstart
telpirion 5ca79e0
build: get the build passing (#17)
yoshi-automation 19e1a8c
build: get sample and system tests passing (#18)
JustinBeckwith bcb3db6
chore(deps): update dependency @types/mocha (#1)
renovate-bot 0e2442d
chore(deps): update dependency c8 to v7 (#2)
renovate-bot 20bb010
chore: release 1.0.0 (#4)
release-please[bot] f0f2cd1
feat: adds CRUD samples for GS realms (#21)
telpirion f707d56
chore: release 1.1.0 (#22)
release-please[bot] 437958d
test: adds cleanup function for tests (#28)
telpirion eb25adf
build: generator updates and new coverage approach (#59)
yoshi-automation cd1fe75
feat: adds CRUD samples, tests for GS clusters (#24)
telpirion 55e4774
chore(deps): update dependency uuid to v8 (#63)
renovate-bot dbd6766
chore: release 2.0.0 (#38)
release-please[bot] 3a4ed17
chore(deps): update dependency mocha to v8 (#72)
renovate-bot f640609
chore: release 2.0.1 (#75)
release-please[bot] cdd0d5e
test: fix sample test by pointing at a shared cluster with Agones (#81)
xwxw-g 3a801b2
chore: release 2.0.2 (#82)
release-please[bot] df6a323
docs(samples): fix sample formatting issues (#94)
pooneh-m f9bee80
docs(samples): Add Game Server deployment samples (#92)
pooneh-m b3744de
docs(samples): change tags to be aligned with golang samples (#97)
pooneh-m 280fdd5
Add samples for GameServerConfigs (#98)
pooneh-m fc11284
Add sample for game server rollout (#102)
pooneh-m 88e03b8
chore: release 2.1.0 (#110)
release-please[bot] 7888188
chore: release 2.1.1 (#133)
release-please[bot] 53d0d7c
chore: release 2.1.2 (#137)
release-please[bot] e4836ee
chore: release 2.2.0 (#143)
release-please[bot] 034c46c
chore: release 2.3.0 (#148)
release-please[bot] 1673277
chore: migrate to owl bot (#153)
SurferJeffAtGoogle 74b48a7
chore: release 2.3.1 (#163)
release-please[bot] acb1cdc
chore: release 2.3.2 (#173)
release-please[bot] 21c26e7
chore: release 2.3.3 (#180)
release-please[bot] 06073a6
chore: release 2.3.4 (#187)
release-please[bot] b243b40
chore: release 2.3.5 (#193)
release-please[bot] a74409e
chore: release 2.3.6 (#197)
release-please[bot] 5279fdd
chore: release 2.3.7 (#199)
release-please[bot] 9629897
chore: release 2.3.8 (#207)
release-please[bot] 24a6f06
chore: release 2.4.0 (#210)
release-please[bot] 6460884
chore: release 2.5.0 (#214)
release-please[bot] 9c82bac
chore: show cluster installation state details for get and list metho…
irataxy 4ab00d4
docs(samples): add auto-generated samples for Node with api short nam…
gcf-owl-bot[bot] c6dc56c
docs: add update samples (#230)
irataxy 0e04fda
build!: update library to use Node 12 (#266)
alexander-fenster d018292
chore(main): release 3.0.0 (#267)
release-please[bot] 2f6b00d
chore(main): release 3.1.0 (#272)
release-please[bot] 189fb36
build: do not test if service is unavailable (#275)
sofisl 712e0d0
chore(main): release 3.1.1 (#307)
release-please[bot] 909231d
chore(deps): update dependency uuid to v9 (#312)
renovate-bot bae504b
chore(main): release 3.1.2 (#314)
release-please[bot] 922317e
Merge remote-tracking branch 'migration/main' into nodejs-game-server…
pattishin 15d7bc3
chore: generate new workflow for migrating game-servers samples
pattishin 07a16b6
Merge branch 'main' into nodejs-game-servers-migration
pattishin 888d590
refactor: resolve merge conflicts
pattishin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| name: apengine-metadata-flexible | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'apengine/metadata/flexible/**' | ||
| pull_request: | ||
| paths: | ||
| - 'apengine/metadata/flexible/**' | ||
| pull_request_target: | ||
| types: [labeled] | ||
| schedule: | ||
| - cron: '0 0 * * 0' | ||
| jobs: | ||
| test: | ||
| if: ${{ github.event.action != 'labeled' || github.event.label.name == 'actions:force-run' }} | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 | ||
| permissions: | ||
| contents: 'write' | ||
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| - uses: 'google-github-actions/[email protected]' | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/[email protected] | ||
| with: | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: apengine/metadata/flexible | ||
| - run: npm test | ||
| working-directory: apengine/metadata/flexible | ||
| env: | ||
| MOCHA_REPORTER_SUITENAME: apengine_metadata_flexible | ||
| MOCHA_REPORTER_OUTPUT: apengine_metadata_flexible_sponge_log.xml | ||
| MOCHA_REPORTER: xunit | ||
| - if: ${{ github.event.action == 'labeled' && github.event.label.name == 'actions:force-run' }} | ||
| uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| try { | ||
| await github.rest.issues.removeLabel({ | ||
| name: 'actions:force-run', | ||
| owner: 'GoogleCloudPlatform', | ||
| repo: 'nodejs-docs-samples', | ||
| issue_number: context.payload.pull_request.number | ||
| }); | ||
| } catch (e) { | ||
| if (!e.message.includes('Label does not exist')) { | ||
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
| ./flakybot --repo GoogleCloudPlatform/nodejs-docs-samples --commit_hash ${{github.sha}} --build_url https://github.com/${{github.repository}}/actions/runs/${{github.run_id}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
|
|
@@ -32,9 +32,9 @@ jobs: | |
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/analytics | ||
| - run: npm test | ||
|
|
@@ -60,7 +60,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
|
|
@@ -32,9 +32,9 @@ jobs: | |
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/building-an-app/build | ||
| - run: npm test | ||
|
|
@@ -60,7 +60,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,19 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/building-an-app/update | ||
| - run: npm test | ||
|
|
@@ -60,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,20 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| credentials_json: '${{ secrets.GOOGLE_CREDENTIALS }}' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/datastore | ||
| - run: npm test | ||
|
|
@@ -61,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,19 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/endpoints | ||
| - run: npm test | ||
|
|
@@ -60,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,19 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/hello-world/flexible | ||
| - run: npm test | ||
|
|
@@ -60,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,19 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/hello-world/standard | ||
| - run: npm test | ||
|
|
@@ -60,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,19 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/memcached | ||
| - run: npm test | ||
|
|
@@ -60,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,20 +22,23 @@ jobs: | |
| pull-requests: 'write' | ||
| id-token: 'write' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v3.1.0 | ||
| with: | ||
| ref: ${{github.event.pull_request.head.ref}} | ||
| repository: ${{github.event.pull_request.head.repo.full_name}} | ||
| <<<<<<< HEAD | ||
| - uses: 'google-github-actions/[email protected]' | ||
| ======= | ||
| - uses: google-github-actions/[email protected] | ||
| >>>>>>> main | ||
| with: | ||
| workload_identity_provider: 'projects/1046198160504/locations/global/workloadIdentityPools/github-actions-pool/providers/github-actions-provider' | ||
| service_account: '[email protected]' | ||
| create_credentials_file: 'true' | ||
| token_format: 'access_token' | ||
| access_token_lifetime: 600s | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v3.5.1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 16 | ||
| - run: npm install | ||
| working-directory: appengine/metadata/standard | ||
| - run: npm test | ||
|
|
@@ -61,7 +64,7 @@ jobs: | |
| throw e; | ||
| } | ||
| } | ||
| - if: ${{ github.event_name == 'schedule' && always() }} | ||
| - if: ${{ github.event_name == 'schedule'}} | ||
| run: | | ||
| curl https://github.com/googleapis/repo-automation-bots/releases/download/flakybot-1.1.0/flakybot -o flakybot -s -L | ||
| chmod +x ./flakybot | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
I think we need to redo the "Add new samples" section from CONTRIBUTING.md for this pull-request.
You will need to:
node .github/workflows/generate.js..github/workflows/game-servers-snippets.yamlfile created by step 2. Do not commit the other files (from.github/workflows) that were created/modified by step 2.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it! 👍🏼