Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run/logging): make tests more robust #2923

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix(run/logging): make tests more robust #2923

merged 1 commit into from
Dec 8, 2022

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Dec 7, 2022

Fixes #2915

@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Dec 7, 2022
@ace-n ace-n force-pushed the fix-2915 branch 7 times, most recently from adeb99a to 1432d3c Compare December 8, 2022 02:35
@ace-n ace-n marked this pull request as ready for review December 8, 2022 02:45
@ace-n ace-n requested review from a team as code owners December 8, 2022 02:45
@averikitsch averikitsch merged commit b576754 into main Dec 8, 2022
@averikitsch averikitsch deleted the fix-2915 branch December 8, 2022 21:56
@ace-n ace-n mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@averikitsch averikitsch averikitsch approved these changes

Assignees
No one assigned
Labels
api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run/logging-manual: "before all" hook for "can be reached by an HTTP request" failed
3 participants
@ace-n @averikitsch @kweinmeister