Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run/logging): throw error if stdout is empty #2942

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Dec 16, 2022

The run/logging-manual sample may occasionally fail to retrieve the underlying Cloud Run service's URL (example). (The URL read from gcloud run services describe appears to be the empty string.)

I'm guessing we can fix this by retrying the command if its stdout is empty. To ensure we log stderr (in case an actual error occurs) during each try, we can raise an error containing the command's stderr.


Fixes #2915

@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Dec 16, 2022
@ace-n ace-n marked this pull request as ready for review December 16, 2022 23:52
@ace-n ace-n requested review from a team as code owners December 16, 2022 23:52
@kweinmeister kweinmeister merged commit e2a606b into main Dec 20, 2022
@kweinmeister kweinmeister deleted the fix-run-logging branch December 20, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run/logging-manual: "before all" hook for "can be reached by an HTTP request" failed
2 participants