fix(run/logging): throw error if stdout is empty #2942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
run/logging-manual
sample may occasionally fail to retrieve the underlying Cloud Run service's URL (example). (The URL read fromgcloud run services describe
appears to be the empty string.)I'm guessing we can fix this by retrying the command if its
stdout
is empty. To ensure we logstderr
(in case an actual error occurs) during each try, we can raise an error containing the command'sstderr
.Fixes #2915