Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for the --disable-setuid-sandbox flag #654

Merged
merged 2 commits into from
Jun 12, 2018
Merged

No need for the --disable-setuid-sandbox flag #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f1f3c7
No need for the --disable-setuid-sandbox flag
glaforge Jun 12, 2018
d2c1ef6
Merge branch 'master' into patch-2
fhinkel Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/headless-chrome/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ app.use(async (req, res) => {

// [START browser]
const browser = await puppeteer.launch({
args: ['--no-sandbox', '--disable-setuid-sandbox']
args: ['--no-sandbox']
Copy link
Contributor

@MylesBorins MylesBorins Jun 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been confirmed in a deplyoment? If I recall the setuid-sandbox was necessary on standard (this was due to the user in standard by default being root, which was disallowed by puppeteer without this flag)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green with and without the flag. @steren, how much confidence do you have in your test? 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it manually on standard. Works fine without the flag.

});
// [END browser]
const page = await browser.newPage();
Expand Down