Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete outdated region tags for trace #916

Closed
wants to merge 1 commit into from
Closed

Delete outdated region tags for trace #916

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Nov 15, 2018

Do not merge until docs are published.

@fhinkel fhinkel added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2018
@fhinkel fhinkel requested a review from engelke November 15, 2018 20:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2018
engelke
engelke approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhinkel
Copy link
Contributor Author

fhinkel commented Nov 29, 2018

Not needed because trace samples are in the client library repository.

@fhinkel fhinkel closed this Nov 29, 2018
@jmdobry jmdobry deleted the traceDeleteOldTags branch December 13, 2018 17:29
@pedroarapua pedroarapua mentioned this pull request Jul 6, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Jul 6, 2023
Open
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
@dlminvestments dlminvestments mentioned this pull request Jul 6, 2023
Merged
@leejh3224 leejh3224 mentioned this pull request Jul 7, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 11, 2023
Open
@aqualen aqualen mentioned this pull request Jul 12, 2023
Open
@ninadhatkar ninadhatkar mentioned this pull request Nov 28, 2023
Open
This was referenced Nov 29, 2023
Open
Open
Open
This was referenced Dec 20, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhinkel @engelke @googlebot