This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Use cloudbuild network for accessing metadata server
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bshaffer |
bshaffer
approved these changes
Sep 26, 2017
added 2 commits
September 25, 2017 21:23
Now the test initializes the LoggingClient and send a log. This ensures the library can access the metadata server to obtain the credentials and detect the project id during the build process.
chingor13
approved these changes
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting an envvar
GCLOUD_PROJECTwhich may be deprecated in the future, it is better to use thecloudbuildnetwork for accessing metadata server.CC: @skelterjohn
Is there any plans for having a public documentation about this?