Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Fix typo in labels #12

Merged
merged 4 commits into from
Feb 26, 2024
Merged

chore(docs): Fix typo in labels #12

merged 4 commits into from
Feb 26, 2024

Conversation

tanisdlj
Copy link
Contributor

No description provided.

@tanisdlj tanisdlj requested review from prabhu34, gtsorbo and a team as code owners February 15, 2024 11:24
@google-cla Google CLA
Copy link

google-cla bot commented Feb 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@apeabody apeabody changed the title Fix typo in labels chore(docs): Fix typo in labels Feb 15, 2024
apeabody
apeabody requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tanisdlj!

Can you please also the source here: https://github.com/GoogleCloudPlatform/terraform-google-artifact-registry/blob/main/variables.tf#L51

@tanisdlj
Copy link
Contributor Author

Thanks for the contribution @tanisdlj!

Can you please also the source here: https://github.com/GoogleCloudPlatform/terraform-google-artifact-registry/blob/main/variables.tf#L51

Done :)

prabhu34
prabhu34 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@prabhu34 prabhu34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prabhu34
Copy link
Collaborator

/gcbrun

@prabhu34
Copy link
Collaborator

/gcbrun

@prabhu34 prabhu34 merged commit b7f8650 into GoogleCloudPlatform:main Feb 26, 2024
4 checks passed
@tanisdlj tanisdlj deleted the patch-1 branch February 27, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody requested changes

@prabhu34 prabhu34 prabhu34 approved these changes

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanisdlj @prabhu34 @apeabody