Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Possibility to ignore external updates. #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Possibility to ignore external updates. #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ resource "google_artifact_registry_repository" "repo" {
}
}
}

lifecycle {
ignore_changes = var.ignore_changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ignore_changes = var.ignore_changes
ignore_changes = [ <ADD THE ATTRIBUTES HERE> ]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabhu34 thanks for the quick reply.

Adding update_time to the ignore_changes meta argument can be considered a deviation from existing functionality. I would still like to see it merged, under the following motivation:

An Artifact Registry is an "object" container in the same way a GCS Bucket and updating a docker image within an Artifact Registry should not trigger any infrastructure changes in the same way that modifying the contents of a GCS Bucket does not trigger any infrastructure changes.

Is this motivation adequate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation seems good as it mentions about changes to the object itself on GCS or Artifact Registry, rather than update time metadata info. Go ahead with the suggestion and we can update later as needed.

}
}

resource "google_artifact_registry_vpcsc_config" "repo_vpc_sc" {
Expand Down
7 changes: 7 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ variable "cleanup_policies" {
default = {}
}


variable "ignore_changes" {
type = list(string)
description = "List of resource attributes to ignore changes for"
default = []
}

Comment on lines +166 to +171
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
variable "ignore_changes" {
type = list(string)
description = "List of resource attributes to ignore changes for"
default = []
}

# VPC SC
variable "enable_vpcsc_policy" {
type = bool
Expand Down
Loading