Improved resource import #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meshuga Thanks you PR |
|
No problem! I believe it'll help solving a lot of issues within the tool but is pretty critical part of the tool. |
|
yes, I working now add retry on read resource for robust process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved resource import. In some cases Terraform is unable to perform resource refresh and the only option that is left is a regular resource import. That import will not import attributes into TF file but should be sufficient for resources with small number of attributes e.g.
aws_iam_role_policy_attachment.The fix might solve other resources that return error Read resource response is null for resource ... e.g. #482 #489 #473 and others
fixes #467