Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import 'cloudflare_access_rule' account & zone scope #517

Conversation

cucxabong
Copy link
Contributor

Fix #516

Support import Access Rule with account & zone scope

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@cucxabong cucxabong force-pushed the import-account-access-rules branch from 2dc0914 to 0884891 Compare May 29, 2020 12:52
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sergeylanzman
Copy link
Collaborator

@cucxabong Thanks for your PR
Can you fixed lint issue?

@cucxabong cucxabong force-pushed the import-account-access-rules branch from 0884891 to 6d92614 Compare May 30, 2020 12:44
@cucxabong
Copy link
Contributor Author

@sergeylanzman fixed, thank you

@sergeylanzman sergeylanzman merged commit 25a6b60 into GoogleCloudPlatform:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloudflare] 'cloudflare_access_rule' error
3 participants