Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support riscv64 #1268

Closed
wants to merge 1 commit into from
Closed

Conversation

ernado
Copy link

@ernado ernado commented Mar 16, 2023

No description provided.

@loosebazooka
Copy link
Member

I probably need some strong justification for this. Adding arches to the build is quite expensive and makes it harder to maintain.

@ernado
Copy link
Author

ernado commented Mar 16, 2023

Totally agree!

I'm currently working on riscv64 support for Kubernetes, which uses distroless (AFAIK) and also requires etcd image.

I've been asked to use distroless in etcd-io/etcd#15490 while adding riscv64 support to etcd.

@@ -1,6 +1,6 @@
# debian 11
- distros: ["debian11"]
archs: ["amd64", "arm64", "arm", "s390x", "ppc64le"]
archs: ["amd64", "arm64", "arm", "s390x", "ppc64le", "riscv64"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

riscv64 should be limited to only the static images and dependencies. This will reduce impact on the build.

There's no need to pull in all packages for riscv64

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time!

How should I update this file?

Also I've got following error while trying ./updateWorkspaceSnapshots.sh:

..URL: https://snapshot.debian.org/archive/debian/20230314T211539Z/dists/bullseye/main/binary-riscv64/Packages.xz, Status: 404 NOT FOUND
panic: failed (status: 404) to fetch remote file: "https://snapshot.debian.org/archive/debian/20230314T211539Z/dists/bullseye/main/binary-riscv64/Packages.xz"

So there is no snapshot for riscv64.
Is it even possible to proceed having this error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly I don't know where the riscv64 images even come from. I can't even find the non-snapshot repo (after taking a quick look). Best I could find is that the port is still "in progress" -- https://www.debian.org/ports/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, looks like I've got it now, sorry, I've updated BUILD file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would probably need the team that owns that port to commit to some sort of snapshotting for this to even work.

@ernado ernado marked this pull request as draft March 16, 2023 18:27
@ernado
Copy link
Author

ernado commented Mar 16, 2023

Looks like it is not possible until riscv64 is in https://www.debian.org/ports/.

@ernado ernado closed this Mar 16, 2023
@ernado ernado mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants