Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POWER & Z architecture support #1462

Closed
bahetiamit opened this issue Oct 20, 2020 · 3 comments · Fixed by #1749 or #1769
Closed

POWER & Z architecture support #1462

bahetiamit opened this issue Oct 20, 2020 · 3 comments · Fixed by #1749 or #1769

Comments

@bahetiamit
Copy link
Contributor

We are working on adding POWER (ppc64le) and Z (s390x) architecture support for https://github.com/tektoncd/pipeline. Pipeline uses kaniko and I would like to know if kaniko is willing to add similar support.
@mattmoor
Copy link
Collaborator

Something else to consider here would be to use the qemu-based buildx support to build/publish the kaniko Dockerfiles, and dropping the Bazel stuff I added.

Travis supports s390x and Power, so we could do more testing that way.

I went the Bazel route because it was familiar from the work in distroless, and hadn't messed with the buildx QEMU support, but have now and it's neat. AFAIK Bazel is the main limiting factor here, so I'd be happy to see it go if we can move the needle on multi-arch.

@bahetiamit bahetiamit mentioned this issue Oct 30, 2020
Merged
4 tasks
@katheris
Copy link

Hi, great to see multi-arch support. Am I right in thinking that Z (s390x) support has not been added to Kaniko yet?

kun-lu20 added a commit to linux-on-ibm-z/kaniko that referenced this issue Sep 23, 2021
@kun-lu20
Add s390x support to docker images
8d98aaf 
1. add s390x support to docker images `executor`, `executor(slim)`,
   `executor(debug)` and `warmer`. Fixes GoogleContainerTools#1462 and GoogleContainerTools#1665.

2. Address the building issue of dependency `docker-credential-gcr`
   in Dockerfiles. This issue was introduced when recent commits
   in `docker-credential-gcr` removed the Makefile.

Signed-off-by: Kun-Lu <[email protected]>
@kun-lu20 kun-lu20 mentioned this issue Sep 23, 2021
Merged
4 tasks
tejal29 pushed a commit to tejal29/kaniko that referenced this issue Oct 19, 2021
@kun-lu20 @tejal29
Add s390x support to docker images
9d71191 
1. add s390x support to docker images `executor`, `executor(slim)`,
   `executor(debug)` and `warmer`. Fixes GoogleContainerTools#1462 and GoogleContainerTools#1665.

2. Address the building issue of dependency `docker-credential-gcr`
   in Dockerfiles. This issue was introduced when recent commits
   in `docker-credential-gcr` removed the Makefile.

Signed-off-by: Kun-Lu <[email protected]>
@tejal29 tejal29 mentioned this issue Oct 19, 2021
Merged
tejal29 added a commit that referenced this issue Oct 19, 2021
@tejal29 @kun-lu20
Add s390x support to docker images (#1769)
badd665 
1. add s390x support to docker images `executor`, `executor(slim)`,
   `executor(debug)` and `warmer`. Fixes #1462 and #1665.

2. Address the building issue of dependency `docker-credential-gcr`
   in Dockerfiles. This issue was introduced when recent commits
   in `docker-credential-gcr` removed the Makefile.

Signed-off-by: Kun-Lu <[email protected]>

Co-authored-by: Kun-Lu <[email protected]>
@tejal29 tejal29 reopened this Oct 20, 2021
@tejal29
Copy link
Contributor

tejal29 commented Oct 20, 2021

This was reverted as docker builds were failing.

imjasonh pushed a commit that referenced this issue Jan 6, 2022
@kun-lu20
Add s390x support to docker images (#1749)
ccaa38d 
* Add s390x support to docker images

1. add s390x support to docker images `executor`, `executor(slim)`,
   `executor(debug)` and `warmer`. Fixes #1462 and #1665.

2. Address the building issue of dependency `docker-credential-gcr`
   in Dockerfiles. This issue was introduced when recent commits
   in `docker-credential-gcr` removed the Makefile.

Signed-off-by: Kun-Lu <[email protected]>

* Add s390x support to all images except debug image

* Add s390x support to images.yaml

* Fix ld64.so.1 not found issue on s390x

* Add a comment for copying /lib from busybox container on s390x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tejal29 @mattmoor @katheris @bahetiamit