-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.8.0 #1871
Comments
Thanks @imjasonh for bringing this up. I am OOO. Will check if someone can help with the release. |
Thanks @tejal29! I think #970 (comment) might be an issue we should resolve before cutting a release. I don't personally have much context on it but maybe someone else does. |
Hi @imjasonh , hope all is well. Do you have any updates reg releasing v1.8.0? Thank you very much! |
I believe we're ready to go (someone please let me know if there are blocking issues!). Just waiting on @tejal29 or someone else from Google's side to give us the go-ahead, and to be around in case we need to do an emergency rollback like we did for v1.6.0->v1.7.0. In the meantime it'd be really useful to get feedback on the pre-release commit-tagged images ( @briandealwis any thoughts? |
Just tried running Kaniko (latest, 1.6.0) with an updated docker-credential-gcr (2.1.0), and it still produces the error of #1786. So the issue might be caused by how the new docker-credential-gcr behaves. |
I have another question about the release process, which we should clear up before cutting a new release: how is the There's GitHub Actions config in place to build and push the image on pushes to the repo, and to tag I think we should make sure we won't accidentally release the image twice (and possibly subtly differently), and I'd like to suggest that we use the GitHub Actions flows instead of GCB -- they're more publicly auditable, logs are public, and it's already how we're pushing commit-tagged images. If the GCB configs aren't used, we can just delete them. @tejal29 @briandealwis do either of you know? |
What about #1791, is a fix for that planned for 1.8.0? |
I believe that's been fixed by all the auth refactoring since v1.7.0, but as always, testing with a commit-tagged image to verify would be helpful! |
Wondering if there is an expected release timeframe for 1.8.0. Running into #1789 on 1.7.0 but head seems to be fine (saw that the change was reverted). Thanks :D |
Hi everyone! Just want to check in to let everyone know we're looking into cutting a new release soon. 🙏 I'm new to the project so I'll need a bit of time to ramp up, but I'm looking to make sure this happens by ~early March. |
This is done now! https://github.com/GoogleContainerTools/kaniko/releases/tag/v1.8.0 🎉 Thanks @chuangw6 |
Hi @imjasonh ,
|
Indeed! I'm also not seeing that image The
This was the first time our actual release process was exercised, so it seems there are some bugs: it should tag the image as Someone with GCR permissions should be able to fix this with:
And we should fix whatever bug in the GitHub Actions workflow caused this. |
I am afraid #1821 is still triggering when trying to upgrade to tag |
I'm facing this issue with 1.8.0-debug and with 1.8.1-debug
I double checked the service account permissions many many times, storage admin and google container agent. What else do I need? I'm a little bit lost here... Even if I go to 1.6 or 1.5 I got the same error, clearly the error is on my side, but I'm totally lost. |
create secret
#1821 is still triggering☹ |
v1.7.0
was cut in October, then rolled back due to an issue with GCR auth -- the tag wasn't removed, but:latest
was changed to point to:v1.6.0
.Issues: #1821 #1805 #1791 #1786
Since #1856 I believe these auth issues should be resolved, and I think it would be a good idea to cut a
:v1.8.0
to get this change and others since v1.6.0 out to users.It looks like there's also #1789, which might be a regression in v1.7.0, which I can take a look at before v1.8.0.
@tejal29 @briandealwis wdyt? I don't have the necessary permissions to rollback the tag in GCR manually, only via GitHub Actions release workflows, so I'd love to have your go-ahead before proceeding.
The text was updated successfully, but these errors were encountered: