Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main branch contains older ECR helper than 1.7.0 #1879

Closed
Vrtak-CZ opened this issue Jan 13, 2022 · 3 comments · Fixed by #1880
Closed

Main branch contains older ECR helper than 1.7.0 #1879

Vrtak-CZ opened this issue Jan 13, 2022 · 3 comments · Fixed by #1880

Comments

@Vrtak-CZ
Copy link

Actual behavior
I do not understand the reason why ECR Credentials Helper got downgraded from 0.5.0 to 0.4.0. The 0.4.0 does not support ECR public registry (0.5.0 does).

ella:~:% podman run --rm --entrypoint "" gcr.io/kaniko-project/executor:v1.7.0-debug /kaniko/docker-credential-ecr-login -v    

amazon-ecr-credential-helper
Version:    0.5.0
Git commit: b94b92f

The change was introduced here f694212

Expected behavior
Upgrade main branch back to 0.5.0 to support ECR Public registry

To Reproduce
Steps to reproduce the behavior:

  1. RUN go install github.com/awslabs/amazon-ecr-credential-helper/ecr-login/cli/[email protected]
  2. RUN go install github.com/awslabs/amazon-ecr-credential-helper/ecr-login/cli/[email protected]
Description Yes/No
Please check if this a new feature you are proposing
Please check if the build works in docker but not in kaniko
Please check if this error is seen when you use --cache flag
Please check if your dockerfile is a multistage dockerfile
@Vrtak-CZ
Copy link
Author

I think this should block #1871

@imjasonh
Copy link
Collaborator

Weird, I'm not sure why I did that either. Fixed in #1880, and I agree we should do it before cutting a new release.

Thanks for noticing this! 👍

@imjasonh
Copy link
Collaborator

FWIW #1872 should also help, since our dependency on cred helpers will be tracked in go.mod, and Dependabot can propose upgrades for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants