Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request custom /path on registry maps including fallback #3046

Closed
prima101112 opened this issue Mar 6, 2024 · 5 comments
Closed

Request custom /path on registry maps including fallback #3046

prima101112 opened this issue Mar 6, 2024 · 5 comments
Labels
feat/registry-mirror fix-suggested priority/p1 Basic need feature compatibility with docker build. we should be working on this next.

Comments

@prima101112
Copy link
Contributor

Problem

we have a problem when using --registry-mirror its limited the default to just /library
could we just make this option out to the config
--mirror-prefix

we want to move the default docker hub with harbor proxy that actually go to dockerhub
but the harbor is not in the library instead on another prefix
correlated with issue
#1618 and #2471

and changes the

func normalizeReference(ref name.Reference, image string) (name.Reference, error) {
	if !strings.ContainsRune(image, '/') {
		return name.ParseReference("library/"+image, name.WeakValidation)
	}

	return ref, nil
}

https://github.com/GoogleContainerTools/kaniko/blob/main/pkg/image/remote/remote.go#L120

need feedback if its allowed we may pull request

@prima101112 prima101112 changed the title Request Feature [Kind of] Request Flag --mirror-prefix Mar 6, 2024
@prima101112 prima101112 changed the title Request Flag --mirror-prefix Request custom /path on registry maps including fallback Mar 6, 2024
@prima101112
Copy link
Contributor Author

just adding PR also #3048

@JeromeJu JeromeJu added priority/p1 Basic need feature compatibility with docker build. we should be working on this next. feat/registry-mirror fix-suggested labels Mar 15, 2024
@JeromeJu
Copy link
Collaborator

Hi @prima101112 , thanks for filing this and the PR, please feel free to assign me for the rebased PR once it's ready.

@prima101112
Copy link
Contributor Author

@JeromeJu already fix on this PR #3051 #3051

@JeromeJu
Copy link
Collaborator

Thanks will take a look

@prima101112
Copy link
Contributor Author

PR already merged. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/registry-mirror fix-suggested priority/p1 Basic need feature compatibility with docker build. we should be working on this next.
Projects
None yet
Development

No branches or pull requests

2 participants