Kaniko/add path regmaps [possible in registry maps and/or mirror] #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @aaron-prindle including @mlec1 that review the old pr |
|
also this sir @JeromeJu please review |
prima101112
force-pushed
the
kaniko/add-path-regmaps
branch
from
b9ae8c4 to
a30b4b6
Compare
pkg/image/remote/remote.go
Outdated
| for _, regToMapTo := range newRegURLs { | ||
|
|
||
| //ectract custom path if any in all registry map and clean regToMapTo to only the registry without the path |
There was a problem hiding this comment.
nit: typo s/ectract/extract
|
Thanks for the PR @prima101112! I think there's one typo in a related comment, once that's updated we can merge |
prima101112
force-pushed
the
kaniko/add-path-regmaps
branch
from
a30b4b6 to
52a2dba
Compare
|
thanks @aaron-prindle for the comment. fix the typo and rebased again. kindly check |
aaron-prindle
approved these changes
Mar 22, 2024
|
LGTM, thanks for the PR @prima101112! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2471 , #1618 and my own #3046
Description
add the path when we want --registry-map #1618 and #2471
with path in the mirror.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes