Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract filesystem in order of layers rather than in reverse #325

Closed
priyawadhwa opened this issue Aug 29, 2018 · 1 comment
Closed

Extract filesystem in order of layers rather than in reverse #325

priyawadhwa opened this issue Aug 29, 2018 · 1 comment

Comments

@priyawadhwa
Copy link
Collaborator

After prototyping caching layers for kaniko, I've been thinking it might make more sense to extract the file system layers in order rather than in reverse. When we extract cached layers onto the filesystem, we're essentially extracting the layers "forwards", so it doesn't make sense to extract the base image "backwards" anymore since we have to remove whiteout files specified in cached layers from the file system anyway.

This should also make the hardlink problem from #282 easier to solve.

@dlorenc WDYT?
priyawadhwa pushed a commit to priyawadhwa/kaniko that referenced this issue Aug 29, 2018
Extract filesystem in order rather than in reverse
920e086 
Extracting the layers of the filesystem in order will make it easier to
extract cached layers and deal with hardlinks, as mentioned in GoogleContainerTools#284

This PR implements extracting in order and adds an integration tests to
test the bug hardlinks error in GoogleContainerTools#284

It also fixes GoogleContainerTools#325
priyawadhwa pushed a commit to priyawadhwa/kaniko that referenced this issue Aug 29, 2018
Extract filesystem in order rather than in reverse
88c0ba4 
Extracting the layers of the filesystem in order will make it easier to
extract cached layers and deal with hardlinks, as mentioned in GoogleContainerTools#284

This PR implements extracting in order and adds an integration tests to
test the bug hardlinks error in GoogleContainerTools#284

It also fixes GoogleContainerTools#325
@priyawadhwa
Copy link
Collaborator Author

Closing, fixed by #326

@priyawadhwa priyawadhwa mentioned this issue Aug 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@priyawadhwa