Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky integration test #472

Closed
priyawadhwa opened this issue Nov 27, 2018 · 4 comments
Closed

Flaky integration test #472

priyawadhwa opened this issue Nov 27, 2018 · 4 comments
Labels
area/testing Issues related to testing kaniko itself good first issue Good for newcomers help wanted Looking for a volunteer! kind/bug Something isn't working

Comments

@priyawadhwa
Copy link
Collaborator

We should look into this flaky integration test:

--- FAIL: TestLayers/test_layer_Dockerfile_test_meta_arg (8.38s)
integration_test.go:241: Difference in number of layers in each image is 1 but should be 0. Image 1: Image: [gcr.io/kaniko-test/docker-dockerfile_test_meta_arg] Digest: [b14452bdb444ddad9ab2c2d85cc4d9114abb91e4d43d815de5d6b4bbccb5e4b9] Number of Layers: [3], Image 2: Image: [gcr.io/kaniko-test/kaniko-dockerfile_test_meta_arg] Digest: [3bde6500d9a626e06fc7abb126dfc2ff77175aaa037b72ea76ff39eaa7aa87e0] Number of Layers: [2]
@priyawadhwa priyawadhwa added the area/testing Issues related to testing kaniko itself label Nov 27, 2018
@bobcatfish
Copy link
Contributor

oh noes, not again!!

Did this just start flaking recently @priyawadhwa or has it been going for a while?

@bobcatfish bobcatfish added kind/bug Something isn't working help wanted Looking for a volunteer! good first issue Good for newcomers labels Nov 30, 2018
@priyawadhwa
Copy link
Collaborator Author

I noticed it a couple days ago with #459, seems like the number of layers is sometimes what we expect and sometimes off by one!

@sharifelgamal
Copy link
Contributor

This is related to how we treat empty layers, I'm not sure why we sometimes build the extra layer and sometimes not.

@dlorenc
Copy link
Collaborator

dlorenc commented Dec 20, 2018

I think I sent a fix for this in #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues related to testing kaniko itself good first issue Good for newcomers help wanted Looking for a volunteer! kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bobcatfish @dlorenc @priyawadhwa @sharifelgamal