Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite existing dest when copying symlink and preserve link target #459

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

aduong
Copy link
Contributor

@aduong aduong commented Nov 18, 2018

This behaviour is in line with the Docker builder reference:

If <dest> does not end with a trailing slash, it will be considered a regular file and the contents of <src> will be written at <dest>.

https://docs.docker.com/engine/reference/builder/#copy

Fixes #442, #437

@container-tools-bot
Copy link
Collaborator

Hi @aduong. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aduong
Copy link
Contributor Author

aduong commented Nov 22, 2018

I see that the integration test run was unsuccessful. It succeeds locally but I don't have access to the kokoro data. How should I proceed here?

@priyawadhwa
Copy link
Collaborator

@aduong looks like a flaky test, I'll rerun kokoro.

@aduong
Copy link
Contributor Author

aduong commented Nov 29, 2018

Looks like that was it. All checks pass now.

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyawadhwa priyawadhwa merged commit 0b7fa58 into GoogleContainerTools:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants