Add func to append to ignorelist #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
force-pushed
the
add-to-ignore-list
branch
from
00c5ff8 to
d962ab9
Compare
This allows those using Kaniko as a library to add ignored dirs and files without needs to modify /proc/self/mountinfo or doing other strange things with mount -t tmpfs
jkutner
force-pushed
the
add-to-ignore-list
branch
from
d962ab9 to
0a0b4f1
Compare
|
Thanks @jkutner. Very curious to know which tool is using kaniko as a library. |
|
@tejal29 We're prototyping a new feature in Cloud Native Buildpacks that will use kaniko snapshotting under the hood. I'd be happy to chat about it in more detail (you can ping me on our slack or via email). I really appreciate your support in accepting this changes. kaniko is working really well for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
AddToIgnoreListfunc toutilpackage.This allows those using Kaniko as a library to add ignored dirs and files without needs to modify
/proc/self/mountinfoor doing other strange things withmount -t tmpfsSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes