Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .docker/config.json path #1699

Closed

Conversation

julianxhokaxhiu
Copy link

Fixes #1455 as well as many others that can be found here: https://github.com/GoogleContainerTools/kaniko/issues?q=is%3Aissue+is%3Aopen+ecr+push

Description

Apparently in the overall documentation it's stated to put the docker config.json inside of /kaniko/.docker but kaniko seems to request the file in /root/.docker which makes sense as the container uses UID 0 ( when running whoami ). Therefore, update the path in the documentation.

Submitter Checklist

N/A - Documentation

Reviewer Notes

N/A - Documentation

Release Notes

N/A - Documentation

Apparently in the overall documentation it's stated to put the docker config.json inside of `/kaniko/.docker` but kaniko seems to request the file in `/root/.docker` which makes sense as the container uses UID 0 ( when running `whoami` ). Therefore, update the path in the documentation.
@google-cla
Copy link

google-cla bot commented Jul 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Jul 15, 2021
@julianxhokaxhiu
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Jul 15, 2021
@julianxhokaxhiu julianxhokaxhiu deleted the patch-1 branch July 16, 2021 11:51
@julianxhokaxhiu
Copy link
Author

Apparently without even touching the .docker/config.json kaniko is able to push to ECR anyway, just having the right AWS config file in the right path /root/.aws/config is enough.

Closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko failing to push to ECR
1 participant