Fix calculating path for copying ownership #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvaps
force-pushed
the
fix-copying-ownership
branch
from
fa22eee to
0700c32
Compare
|
Thanks! Can you fix the |
|
What do you mean? I have gofmt enabled by default in my editor |
There's an unrelated If you don't feel like doing it that's fine (it's not your fault) but then I'll need to find someone else to approve my PR. 😕 |
|
Ah, got it! I didn't noticed the failed pipeline |
kvaps
force-pushed
the
fix-copying-ownership
branch
from
bd29298 to
2801433
Compare
|
please give me more time, I'll fix it tomorrow |
No rush, thanks for working on this! |
kvaps
force-pushed
the
fix-copying-ownership
branch
from
2801433 to
d2f1a46
Compare
|
All jobs passed |
imjasonh
approved these changes
Dec 24, 2021
gcalmettes
pushed a commit
to gcalmettes/kaniko
that referenced
this pull request
Dec 24, 2021
* Fix calculating path for copying ownership * fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description
This PR:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes