Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub Actions on pushes and PRs to main, not master #1883

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

imjasonh
Copy link
Collaborator

At some point in the last week or so, this repo's default branch was changed from master to main (by whom, I don't know, there doesn't seem to be any record of it).

Since GitHub Actions workflows were only configured to run on pushes and PRs to master, these weren't run, for example, on #1866

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@imjasonh imjasonh requested a review from priyawadhwa January 14, 2022 18:20
Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this was my bad, sorry I should have opened an issue before I made the change! Thanks for fixing it :)

@imjasonh
Copy link
Collaborator Author

Yup this was my bad, sorry I should have opened an issue before I made the change! Thanks for fixing it :)

No worries, thanks for switching to main!

@imjasonh
Copy link
Collaborator Author

The remaining integration test failure (link) fails because docker build's behavior when asked to use a Git repo as a build context without a ref specified is to fetch master -- and this repo no longer has one of those :(

Should we:
a. skip the test with a TODO to fix it later, temporarily lose test coverage of this behavior
b. remove the test, ~permanently lose test coverage
c. switch the repo to some other repo that does have a master, and take an implicit dependency on this other repo

@priyawadhwa
Copy link
Collaborator

I would probably go with (a)! (c) is also fine but I'd probably only do it if you already have a repo in mind.

@imjasonh imjasonh merged commit d587122 into GoogleContainerTools:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants