Bump golangci lint #2400
Closed
Bump golangci lint #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
- Adapted error comparison according to linter recommendation - Disabled noctx linting for http request where canceling makes no sense - Disabled nilerror linting where nil error is returned on purpose - Disabled makezero linter where slice is explicitly deepcopied
BronzeDeer
force-pushed
the
bump-golangci-lint
branch
from
84b13c4 to
92ce78c
Compare
|
Fixed an issue in which gofmt would reformat the boilerplate if there was no empty line between it and the package declaration. If gofmt reformats the blockcomment of the boilerplate, the boilerplate detection fails. The fix gofmt commit now adds the blank lines for consistency across the whole codebase, a more durable fix would likely be to make the boilerplate detection also ignore leading and trailing whitespace changes in the boilerplate |
imjasonh
approved these changes
Mar 20, 2023
|
#2425 is merged, so this should no longer be needed right? (Closing; let me know if I should reopen) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #2384 it was discovered that the older golangci-lint version does not support go 1.20. This PR bumps golangci-lint to the newest release (1.51.1) and fixes all newly discoverd gofmt, goimport and linting errors
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
No new features were added, so no tests needed to be written
Reviewer Notes