-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ACR credential helper to enable Azure Workload Identity #2431
Update ACR credential helper to enable Azure Workload Identity #2431
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Nice! Can you also bump the version that gets compiled into the code and executed when cred helpers aren't available? Line 18 in fe2413e
|
@imjasonh the version is bumped |
Thanks! You'll also need to accept the Google CLA before this can be merged: https://github.com/GoogleContainerTools/kaniko/pull/2431/checks?check_run_id=12027296256 |
@imjasonh Thanks, CLA is signed |
@imjasonh for the some reasons all tests failed. What happened? |
You'll need to run |
@imjasonh Done |
@imjasonh resolved merge conflicts |
Description
Bump the version of ACR Credential helper to support Azure Workload Identity for Kaniko pods