Fix fs_util tests failing on systems with /tmp mountpoint #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string points to /proc/self/mountinfo
The tests * Test_GetFSFromLayers_ignorelist * Test_GetFSFromLayers_with_whiteouts_include_whiteout_disabled * Test_GetFSFromLayers_with_whiteouts_include_whiteout_enabled were failing on systems with a /tmp mountpoint: fs_util.InitIgnoreList() adds all mountpoints to the ignore list, but the tests were expecting file operations in a /tmp subdirectory. This change provides an empty mountinfo list for the affected tests. Fixes GoogleContainerTools#1779
aaron-prindle
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Thank you @andreasf for the fix and detailed description here, LGTM!
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
…ainerTools#2583) * Rename IgnoreListPath to MountInfoPath in config & constants The string points to /proc/self/mountinfo * fs_util_test.go: fix tests failing when /tmp mountpoint present The tests * Test_GetFSFromLayers_ignorelist * Test_GetFSFromLayers_with_whiteouts_include_whiteout_disabled * Test_GetFSFromLayers_with_whiteouts_include_whiteout_enabled were failing on systems with a /tmp mountpoint: fs_util.InitIgnoreList() adds all mountpoints to the ignore list, but the tests were expecting file operations in a /tmp subdirectory. This change provides an empty mountinfo list for the affected tests. Fixes GoogleContainerTools#1779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1779
The tests
were failing on systems with a /tmp mountpoint:
fs_util.InitIgnoreList() adds all mountpoints to the ignore list, but the tests were expecting file operations in a /tmp subdirectory.
This change provides an empty mountinfo list for the affected tests.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes