Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more information regarding --use-new-run #2687

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

aaron-prindle
Copy link
Collaborator

fixes #2575

@aaron-prindle aaron-prindle requested a review from JeromeJu August 18, 2023 18:27
Copy link
Collaborator

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aaron-prindle
lgtm

@aaron-prindle aaron-prindle merged commit 8a0af16 into GoogleContainerTools:main Aug 18, 2023
@@ -1068,8 +1068,12 @@ Set this flag to indicate which build stage is the target build stage.

#### Flag `--use-new-run`

Use the experimental run implementation for detecting changes without requiring
file system snapshots. In some cases, this may improve build performance by 75%.
Use the experimental RUN implementation for detecting changes without requiring
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is now broken and incomplete.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if anyone gets notified on PR comments since this is merged, so: @aaron-prindle

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this @braykov, submitted #2698 to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document more clearly what the purpose of the --use-new-run feature is and how it works
3 participants