Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function name on comment #2707

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

geekvest
Copy link
Contributor

@geekvest geekvest commented Aug 28, 2023

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)

Description

fix function name on comment

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@google-cla
Copy link

google-cla bot commented Aug 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@geekvest
Copy link
Contributor Author

I have sign google-cla,please check again

@aaron-prindle
Copy link
Collaborator

Thank you for the PR here @geekvest! I am not sure why given what you stated here but the cla/google check still says that you have not signed the CLA. Perhaps you can try to sign it once more or we can wait a bit to see if it updates over time? Unfortunately we cannot merge this PR unless the cla/google check passes.

@geekvest
Copy link
Contributor Author

Thank you for the PR here @geekvest! I am not sure why given what you stated here but the cla/google check still says that you have not signed the CLA. Perhaps you can try to sign it once more or we can wait a bit to see if it updates over time? Unfortunately we cannot merge this PR unless the cla/google check passes.

Thanks. Signed.

I modified the alias mailbox of github, and it took effect after refreshing

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aaron-prindle aaron-prindle merged commit 5df0343 into GoogleContainerTools:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants