-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skip tls flag for private git context #2854
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@schwannden can you rebase, there was an issue @ HEAD that was recently fixed (this should resolve the test error you are seeing) |
If git clone context is a private self-signed repository, we allow user to add --git insecure-skip-tls=true flag in the option. The value is default to false, this behavior is in accordance with the go-git package.
@aaron-prindle done |
@JeromeJu any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR here @schwannden!
Description
If git clone context is a private self-signed repository, we allow user to add --git insecure-skip-tls=true flag in the option. The value is default to false, this behavior is in accordance with the go-git package.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes