Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#977 upgrade go mod dependencies #978

Closed

Conversation

nonetheless
Copy link

@nonetheless nonetheless commented Jan 19, 2020

upgrade go mod dependencies, direct update:

  • github.com/moby/buildkit v0.6.3
  • github.com/google/go-containerregistry v0.0.0-20200115214256-379933c9c22b

Fixes #977

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jan 19, 2020
Copy link
Contributor

@cvgw cvgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of dependencies changed in this PR; enough to make it high risk IMO.

I would strongly prefer that a single dependency (and any absolutely necessary related dependencies) are updated.

This also seem like it might have overlap with #957

@tejal29
Copy link
Contributor

tejal29 commented Jan 29, 2020

@nonetheless is this PR still needed? #957 is already merged.
Can you rebase this PR to update just buildkit?

@antechrestos
Copy link
Contributor

I've redone this job with current master branch, by just upgrading moby/buildkit to v0.6.3 (2 days later) and go-containerregistry to v0.0.0-20200115214256-379933c9c22b (one month minus end of year holiday) and it gives the following diff of go.mod

Then rm -rf vendor && go mod tidy && go mod vendor && git add vendor gives 1063 modified files.

BTW, I hope there is a go mod tidy verification because the suggested modified files fails as it brings
invalid pseudo-version errors.

@nonetheless nonetheless closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection refused for non-TLS registry URL
6 participants