Bring back applying labels to services deployed with helm #2568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2379
In #965, we turned off labelling services due to kubernetes/kubernetes#68087
This bug is in the kube-controller-manager which runs on the cluster master side.
I tested this PR on my cluster with 1.11.7-gke.4 and port-forwarding for LoadBalancer type services works.
Impacted versions for this bug
As per GKE version skew policy, June 2019 release notes mention GKE will only support the three newest minor versions.
So in june end, for all node pools older than v1.11.X Google will enable node auto-upgrade and these nodes will be updated to 1.11.10-gke.5. ( we are v1.14 now)
In conclusion, i feel this is safe way to enable port-forwarding for services deployed by helm (helm2) to get in.