PR feedback

GoogleForCreators · Jan 5, 2023 · fba8475 · fba8475
1 parent bc3dc68
commit fba8475
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 31 deletions.
diff --git a/packages/design-system/tsconfig.json b/packages/design-system/tsconfig.json
@@ -19,7 +19,6 @@
     "src/types/*",
     "src/types.ts",
     "src/utils/*.ts",
-    "src/utils/*.tsx",
     "src/utils/constants.ts",
     "src/utils/localStore.ts",
     "src/utils/sessionStore.ts"

diff --git a/packages/story-editor/src/app/pageDataUrls/pageDataUrlsProvider.tsx b/packages/story-editor/src/app/pageDataUrls/pageDataUrlsProvider.tsx
@@ -25,39 +25,37 @@ import type { PropsWithChildren } from 'react';
  */
 import useIdleTaskQueue from '../../utils/useIdleTaskQueue';
 import storyPageToDataUrl from '../pageCanvas/utils/storyPageToDataUrl';
-import type { PageDataUrlsState, PageDataUrlsActions } from '../../types';
+import type { PageDataUrls, QueuePageImageGeneration } from '../../types';
 import Context from './context';
-
 function PageDataUrlProvider({ children }: PropsWithChildren<unknown>) {
-  const [dataUrls, setDataUrls] = useState<PageDataUrlsState['dataUrls']>({});
+  const [dataUrls, setDataUrls] = useState<PageDataUrls>({});
   const queueIdleTask = useIdleTaskQueue();
 
   /**
    * Add page image generation task to a idle task
    * queue.
    */
-  const queuePageImageGeneration: PageDataUrlsActions['queuePageImageGeneration'] =
-    useCallback(
-      (storyPage: Page) => {
-        const idleTaskUid: string = storyPage.id;
-        const idleTask: () => Promise<void> = async () => {
-          const dataUrl = await storyPageToDataUrl(storyPage, {});
-          setDataUrls((state) => ({
-            ...state,
-            [storyPage?.id]: dataUrl,
-          }));
-        };
+  const queuePageImageGeneration: QueuePageImageGeneration = useCallback(
+    (storyPage: Page) => {
+      const idleTaskUid: string = storyPage.id;
+      const idleTask: () => Promise<void> = async () => {
+        const dataUrl = await storyPageToDataUrl(storyPage, {});
+        setDataUrls((state) => ({
+          ...state,
+          [storyPage?.id]: dataUrl,
+        }));
+      };
 
-        const clearQueueOfPageTask = queueIdleTask({
-          taskId: idleTaskUid,
-          task: idleTask,
-        });
-        return () => {
-          clearQueueOfPageTask();
-        };
-      },
-      [queueIdleTask]
-    );
+      const clearQueueOfPageTask = queueIdleTask({
+        taskId: idleTaskUid,
+        task: idleTask,
+      });
+      return () => {
+        clearQueueOfPageTask();
+      };
+    },
+    [queueIdleTask]
+  );
 
   const value = useMemo(
     () => ({

diff --git a/packages/story-editor/src/types/pageDataUrls.ts b/packages/story-editor/src/types/pageDataUrls.ts
@@ -19,15 +19,15 @@
  */
 import type { Page } from '@googleforcreators/elements';
 
-export interface PageDataUrlsState {
-  dataUrls: Record<string, string>;
-}
-
 export interface PageDataUrlsActions {
   queuePageImageGeneration: (Page: Page) => void;
 }
 
+export type PageDataUrls = Record<string, string>;
+
+export type QueuePageImageGeneration = (page: Page) => void;
+
 export interface PageDataUrlsContext {
-  state: PageDataUrlsState;
-  actions: PageDataUrlsActions;
+  state: { dataUrls: PageDataUrls };
+  actions: { queuePageImageGeneration: QueuePageImageGeneration };
 }