Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discovery: do not print feed link on post type archive page #12725

Closed
swissspidy opened this issue Nov 22, 2022 · 0 comments · Fixed by #12844
Closed

Discovery: do not print feed link on post type archive page #12725

swissspidy opened this issue Nov 22, 2022 · 0 comments · Fixed by #12844
Assignees
@spacedmonkey
Labels
Group: Discoverability Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

\Google\Web_Stories\Discovery::print_feed_link() adds an RSS feed link for stories if the theme supports automatic-feed-links.

Two issues with that:

  1. There is no filter to disable that output -> let's add one, e.g. web_stories_enable_feed_link
  2. WordPress already prints such a link on the Web Stories archive ( if ( is_post_type_archive( 'web-story' ) )), resulting in duplicate feed links -> we should not add it ourselves in that case

Alternatives Considered

Additional Context
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Group: Discoverability P2 Should do soon Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP labels Nov 22, 2022
@spacedmonkey spacedmonkey self-assigned this Dec 15, 2022
@spacedmonkey spacedmonkey mentioned this issue Dec 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacedmonkey spacedmonkey

Labels
Group: Discoverability Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable feeds on custom post type archive GoogleForCreators/web-stories-wp
2 participants
@spacedmonkey @swissspidy