Disable feeds on custom post type archive #12844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Enhancement
|
Plugin builds for afb8724 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.71 MB ℹ️ View Unchanged
|
swissspidy
reviewed
Dec 15, 2022
includes/Discovery.php
Outdated
Comment on lines
487
to
489
| if ( is_post_type_archive( $this->story_post_type->get_slug() ) ) { | ||
| remove_action( 'wp_head', 'feed_links_extra', 3 ); | ||
| } |
There was a problem hiding this comment.
Instead of this extra method we can just do if ( is_post_type_archive( $this->story_post_type->get_slug() ) ) { return; } in print_feed_link() below.
There was a problem hiding this comment.
I don't like that solution personally 😄
There was a problem hiding this comment.
Why? To me it seems easier to just not do something (i.e. print a feed link) when we know that WP already handles it, instead of unhooking feed_links_extra and then having to adjust this code again when bumping version requirements. That's why I mentioned that approach on the ticket.
swissspidy
changed the title
swissspidy
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Remove the action
feed_links_extraon custom post type archives for web stories. This stop a double print out of rss feed.Relevant Technical Choices
To-do
User-facing changes
Before
After
Testing Instructions
This PR can be tested by following these steps:
/web-stories./web-stories/feed/in the head. See screenshot for examples.Testing, it would be helpful to look at other url types, like single, page, category etc and check the feedback links.
This change will NOT be affected by browser. Validate in chrome and should work everywhere.
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12725