Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests run failure: Test suite failed to run #9636

Closed
miina opened this issue Nov 4, 2021 · 2 comments · Fixed by #12439
Closed

E2E tests run failure: Test suite failed to run #9636

miina opened this issue Nov 4, 2021 · 2 comments · Fixed by #12439
Labels
Needs Tests P3 Nice to have Package: E2E Tests /packages/e2e-tests Type: Bug Something isn't working

Comments

@miina
Copy link
Contributor

miina commented Nov 4, 2021

Bug Description

E2E tests seem to fail consistently on various PR-s even after re-running multiple times.

An example run: https://github.com/google/web-stories-wp/runs/4104763628?check_suite_focus=true#step:11:23

Screenshot 2021-11-04 at 19 16 48

Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

  • Plugin Version:
  • WordPress Version:
  • Operating System:
  • Browser:
@miina miina added Type: Bug Something isn't working Needs Tests Pod: WP & Infra Package: E2E Tests /packages/e2e-tests labels Nov 4, 2021
@swissspidy swissspidy added the P1 High priority, must do soon label Nov 11, 2021
@swissspidy
Copy link
Collaborator

Looks like the culprit is in the packages/e2e-tests/src/specs/wordpress/archive.js test: https://github.com/google/web-stories-wp/runs/4179192112?check_suite_focus=true

@swissspidy swissspidy removed their assignment Nov 24, 2021
@swissspidy swissspidy added P2 Should do soon and removed P1 High priority, must do soon labels Nov 24, 2021
@swissspidy
Copy link
Collaborator

Disabling packages/e2e-tests/src/specs/wordpress/archive.js for now as this takes more time to debug than I thought.

The error might be coming from Puppeteer or elsewhere, and if the this part is correct, it might not even be from within a test:

https://github.com/facebook/jest/blob/7bb400c373a6f90ba956dd25fe24ee4d4788f41e/packages/jest-message-util/src/index.ts#L122-L135

ExecError is an error thrown outside of the test suite (not inside an it orbefore/after each hooks). If it's thrown, none of the tests in the file are executed.

I verified this by skipping all the tests in that file. The error was still occasionally occurring.

@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels Jan 19, 2022
@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2022
swissspidy added a commit that referenced this issue Oct 7, 2022
swissspidy added a commit that referenced this issue Oct 21, 2022
* Improve taxonomies e2e tests

* Add `jest.retryTimes` to every spec file

* Further improve taxonomy tests

* Improve hotlinking tests

* Wrap all `page.waitForNavigation()` calls in `Promise.all`

* Deactivate importer again after install

* Remove `:focus-visible` polyfill

Browser support has much improved this year, with Safari adding support in version 15.4 in March 2022.

Safari 15.4 ships with the iOS and iPadOS 15.4 and macOS 12.3.

* Dynamically import `@mediapipe/selfie_segmentation`

Fixes #12383

* Re-enable admin menu e2e tests

* Re-enable shopify test

See #11994

* Re-enable WooCommerce test

See #11976

* Re-enable story bg audio test

See #12025

* Re-enable font check test

See #11361

* Re-enable story deletion test

See #11362

* Re-enable story saving failing test

See #11992

* Re-enable quick edit test

* Improve status check and re-enable status check tests

See #11991

* Re-enable CORS check test

See #11981

* Re-enable widget tests

See #11990
See #6879

* Re-enable font check metrics test

See #11978

* Make publishPost util more robust

* Re-enable archive page tests

See #9636
See #11990

* Re-enable block widget test

See #11931

* Re-enable pending stories test

See #11993

* Re-enable Site Kit analytics test

See #9985

* Re-enable Web Stories block tests

See #11975
See #6237

* Remove redundant test

See #12023

* Re-enable shopping product test

See #11989

* Re-enable dashboard keyboard navigation test

See #11930

* Re-enable publisher logo test

See #9152

* Add types for `expect-puppeteer` to improve IDE assistance

* Re-enable checklist test

See #11977

* Re-enable some Media3P tests

See #7481

* Remove ext from import

* Remove outdated export

* Re-enable media library test

See #7107

* Avoid using `undefined` as background image

* Re-enable webm video tests

See #11959

* Re-enable media insertion test

See #7107

* Re-enable mov insertion test

See #8232

* Re-enable pre-publish modal poster test

See #7107

* Re-enable pre-publish modal poster test w/ contributor

See #7107

* Remove useless telemetry banner test

See #9619

* Do not prefetch colorthief chunk

* Remove some debug cruft

* Do not use `toMatchElement` return value

* Delete also cropped media in cleanup

* Improve addTextElement util

* Improve previewStory util

* Use sync fs api

* Remove useless check

* Do not use `toMatchElement` return value

* Fix draft-js-export-html dependency entry

* Add types for `expect-puppeteer` to improve IDE assistance

* Do not fail fast for now

* Update browserslist db (#12446)

* Add missing await

* Update to Puppeteer v18

* Improve custom font util

* Bump eslint-plugin-jest from 27.0.4 to 27.1.1 (#12458)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-json from 4.1.0 to 5.0.0 (#12457)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump semver from 7.3.7 to 7.3.8 (#12456)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Disallow closing story takeover dialog (#12440)

* Bump eslint from 8.24.0 to 8.25.0 (#12455)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-node-resolve from 14.1.0 to 15.0.0 (#12454)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @rollup/plugin-url from 7.0.0 to 8.0.0 (#12452)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump css-minimizer-webpack-plugin from 4.2.0 to 4.2.1 (#12453)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @typescript-eslint/parser from 5.39.0 to 5.40.0 (#12451)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump sirbrillig/phpcs-variable-analysis from 2.11.8 to 2.11.9 (#12450)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github/codeql-action from 2.1.26 to 2.1.27 (#12448)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 3.0.2 to 3.1.0 (#12449)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Improve story locking dialog wording and layout (#12447)

Co-authored-by: Jonny Harris <[email protected]>

* Run tests against WordPress 6.1 RC (#12412)

* [WIP] CI: Use composite actions (#12438)

* Composer update

* Add checkout step

* Revert "Add checkout step"

This reverts commit 07ef47b.

* Revert "[WIP] CI: Use composite actions (#12438)"

This reverts commit 6347baf.

* Revert "Composer update"

This reverts commit faab6ba.

* Lint fix

* Code Quality: Use `preloadImage` in `wp-dashboard` (#12466)

* Code Quality: Fix `preloadImage` function signature (#12468)

* Media: Video Segmentation Prototype (#12335)

Co-authored-by: Jonny Harris <[email protected]>
Co-authored-by: Pascal Birchler <[email protected]>

* Improve widget tests

* Improve publisher logo test

* Remove duplicate entry

* Improve taxonomy test

* Fix workflow

* Fix fail-fast

* Update lock file

* Update dashboard test

* Improve widget tests

* Fix password protected story test

* Improve createNewTerm util

* Try improving `addCategory` util

* Update to Puppeteer v19

* Improve `addTextElement`

* Adjust `previewPage`

* Try patching jest-environment-puppeteer

* Update `previewStory` util

* Improve addTextElement

* Fix patch

* Update patch

* Fix zero width chars

* Remove patch

* Fix publishing flow test

See #11970

* Update `addTextElement`

* Refactor `deleteWidgets`

* Adjust publisher logo test

* Improve web stories block test

Don’t use request interception for block test, fix AMP validation

* Add env var

* Add fix for REST API change in 6.1

See https://make.wordpress.org/core/2022/10/11/miscellaneous-rest-api-improvements-in-wordpress-6-1/

* Wait for dialog to be dismissed

* Adjust author test

* Add hardening

* Update lock file

* Adjust widget test

* Adjust font check test

* Increase retry times

* Retry unit tests with AMP validation

* A few focus-visible fixes

* Fix selfie segmentation lazy load

* More rigorously trash posts between tests

Co-authored-by: Google for Creators Bot <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jonny Harris <[email protected]>
Co-authored-by: Tim Arney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests P3 Nice to have Package: E2E Tests /packages/e2e-tests Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants