Story Poster: Use dimensions array instead of size name #12418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Bug
|
Plugin builds for a1b6616 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
|
Does it work? As discussed, would be nice to have some sorts of tests verifying that this actually solves the reported bug. With this approach here it should be doable to that with PHP tests alone, no E2E tests needed (though that would be the last resort). Alternatively, if we can't have tests, at the very least we should add comments explaining why we do it that way. |
|
@swissspidy Unit tests added. Closing other PR in favour of this. |
8 tasks
timarney
reviewed
Oct 5, 2022
tests/phpunit/integration/tests/REST_API/Stories_Controller.php
Outdated
Show resolved
Hide resolved
timarney
reviewed
Oct 5, 2022
tests/phpunit/integration/tests/REST_API/Stories_Controller.php
Outdated
Show resolved
Hide resolved
timarney
reviewed
Oct 5, 2022
tests/phpunit/integration/tests/REST_API/Stories_Controller.php
Outdated
Show resolved
Hide resolved
|
The tests don't work, as in, they demonstrate the bugfix. If I undo the changes to Note that for the QA instructions you can reuse the reproduction steps from the issue. |
The fix does work, I just used the wrong test data. I have updated the fixture data and tests pass and you can see them pass. |
|
When I undo the changes to |
This comment was marked as resolved.
This comment was marked as resolved.
swissspidy
requested changes
Oct 17, 2022
swissspidy
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This still needs to be addressed AFAICT. After that this should be ready. |
I believe I fixed these issues with new test data. |
|
Just verified that it's still an issue. 3be82da was the only change since I flagged this. |
|
Excellent! 🎉 |
swissspidy
approved these changes
Oct 19, 2022
|
Reproduced this problem (thanks to @LuckynaSan and @spacedmonkey for your help) by following these steps:
Verified the fix by loading the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Another solution to #12354. If you pass an array of dimensions instead of passing size name it bypasses the content width check. See
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12354