Delete a non-draft story from storage after saving #12475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for b5a219e are ready 🛎️!
|
|
Size Change: +14 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
Plugin builds for a579d5e are ready 🛎️!%0A- Download development build%0A- Download production build |
barklund
approved these changes
Oct 19, 2022
Comment on lines
+109
to
+110
| if (wasNewTracker.current) { | ||
| sessionStore.deleteItemByKey(getSessionStorageKey(null, true)); |
There was a problem hiding this comment.
Note the prettiest code ever, but if it works... 🤷
|
Confirmed that the
in all cases, so soon as the saved changes are restored or saved, the temporary session storage key is deleted. Obviously, if the story has unsaved changes and no one opens the story, the session storage key remains in the browser context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Fixes a bug where a story is not deleted from the session storage when saving the story.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12444