Story Locking: Ensure author users and below correctly see information #12559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Bug
spacedmonkey
commented
Oct 28, 2022
| if (showLockedDialog && currentUserLoaded) { | ||
| getStoryLockById(storyId, stories) | ||
| .then(({ locked, nonce: newNonce, _embedded }) => { | ||
| (async () => { |
There was a problem hiding this comment.
Converted this to async code is not needed for this, but made it easier to read.
|
Plugin builds for bb234cb are ready 🛎️!
|
|
Size Change: -50 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
swissspidy
reviewed
Oct 31, 2022
swissspidy
reviewed
Oct 31, 2022
tests/phpunit/integration/tests/REST_API/Stories_Lock_Controller.php
Outdated
Show resolved
Hide resolved
spacedmonkey
commented
Oct 31, 2022
tests/phpunit/integration/tests/REST_API/Stories_Lock_Controller.php
Outdated
Show resolved
Hide resolved
swissspidy
approved these changes
Oct 31, 2022
|
Just ocurred to me that the dashboard needs changing here as well. Can you check that? see #12604 |
|
@spacedmonkey @swissspidy -- I tested the This take over dialog is different from the one that the Admin-user sees, when Author-user takes over a story that Admin-user was editing: I am not clear which of these two dialogs should appear in Author-users editor when Admin-user takes over the story that Author-user was editing. |
|
Both users can see both dialogs. You see one when trying to open a locked story, the other when someone takes over editing from you. In both cases, users should at all time see the name & avatar of the other user. |
|
Added a fix for #12604 |
swissspidy
approved these changes
Nov 2, 2022
swissspidy
reviewed
Nov 2, 2022
swissspidy
reviewed
Nov 2, 2022
|
@kkalarickal Can you re-test #12604 here? |
|
Confirmed that non-admin users can:
|
|
@swissspidy I noticed that the following and wanted to get your take on if this is ok:
Example: This is the view for Admin user The same dashboard, when viewed by Author user
|
timarney
approved these changes
Nov 3, 2022
|
@kkalarickal Not sure if I understood correctly, but if a user is not allowed to edit a story, then there's no point in showing them that it's currently locked, so that is expected and sounds correct to me. |
swissspidy
changed the title
|
@swissspidy - thank you for confirming. I agree that if user-profile cannot edit a story authored by someone with higher level of access, then there is no need to show the locked/thumbnail. For the scenario where the same user is accessing the Story dashboard from different browser instances, I was thinking we should indicate that another instance is open. However, when I looked at the WP Post workflow - it also does not show the lock-icon or thumbnail for same user login from another browser. So I guess we are at par with WP Post workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Instead of using the embedded user rest api request, just hardcode the user data in the api response.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12441
Fixes #12604