Correctly filter revision fields for story revisions #12611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Bug
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
|
Plugin builds for 7d25e75 are ready 🛎️!
|
spacedmonkey
reviewed
Nov 2, 2022
spacedmonkey
reviewed
Nov 2, 2022
spacedmonkey
approved these changes
Nov 2, 2022
timarney
approved these changes
Nov 3, 2022
spacedmonkey
approved these changes
Nov 3, 2022
|
Confirmed the fix by restoring from a saved version and verifying that the proper version was restored. Comparing revisions Restored web story with 3 pages |
|
Further tests: Confirmed that going back in the revision history and restoring a previous version was successful. Also confirmed that comparing two arbitrary versions and restoring between them works as expected. Verified that restoration works across user-profiles: meaning when one user creates the original story, and another takes over editing, the revision mismatch is caught and restoring someone else's version is possible. Verified that with each restoration, the revision count within Document panel keeps incrementing as expected ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When restoring a story from an autosave, the story content was not correctly restored.
This is because when filtering
_wp_post_revision_fields, the post type can either beweb-storyorrevision, and we didn't check for the latter.Summary
Correctly filter revision fields for story revisions by checking the post parent.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12547