Remove custom rest_preload_api_request fork
#12626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Infrastructure
swissspidy
added
Type: Code Quality
|
Plugin builds for d5c4484 are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
swissspidy
changed the title
rest_preload_api_request.rest_preload_api_request fork
swissspidy
approved these changes
Nov 9, 2022
|
So the e2e tests seem to be failing and from what I can see, the preloading is not actually working anymore. Maybe still an issue with how core's function handles embeds or something. |
|
@swissspidy Sadly, it is seems we were too early on this one. There is another tweak that was made to web-stories-wp/includes/namespace.php Line 211 in 9be7522 |
|
Ah yes, the trailing slashes issue. Wasn't that supposed to be fixed by https://core.trac.wordpress.org/ticket/51636? |
8 tasks
Sadly it seems like it was not :( We can't use that function from core then. |
I will report upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Remove custom
rest_preload_api_requestas not needed with WP 5.9 as min.Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12622