Fix eyedropper test #8530
Merged
Fix eyedropper test #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this supersede #8524? |
|
Size Change: +234 kB (+8%) 🔍 Total Size: 3.13 MB
ℹ️ View Unchanged
|
|
Looks like we have two separate issues:
|
See #7481 for that. Seems like it was introduced in #8320 or at least surfaced by it. See #8320 (comment) and 6614515 for context. |
|
Yea I just put up #8524 to help out. fine if we scrap the entire PR. As for the misalignment issue, once I was able to add media to the canvas, I was getting this part of the test failing: Because of this behavior(notice the zoomed in image bubble isn't pink when the cursor is over the pink image, and it's not until I move the cursor pretty far down on the image that the zoomed in canvas picks up the top of the picture): Kapture.2021-07-30.at.15.07.17.mp4 |
Is this happening only with Media btw? It seems to me that it's also happening to other elements that use Moveable (e.g. reload the page, go to the Shapes tab quickly and try inserting one). I'm guessing that since |
|
This fix is still useful (just the Moveable part was removed), let's merge it (one ✅ needed). |
|
There's this one screenshot on Percy where the eyedropper hasn't fully loaded yet. Flakey, bug, or expected change? |
Fixed (kinda expected because the whole Color Picker is now lazy-loaded). |
swissspidy
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
QA
This PR can be tested by following these steps:
UAT
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #