fix: support grafana 8.3.x #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Resolves #139 |
|
@geryepes For me it looks good. However it would be better for a regular contributor to make the review, as i haven't worked on grafana plugins. Nice work by the way :) |
|
Anyone? Please merge it. |
|
I can look into after 7 Days. On PTO
…On Thu, 3 Feb 2022 at 11:32 PM, vicioussn ***@***.***> wrote:
Anyone? Please merge it.
—
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXQD33I7RTQT233TZRWLTUZK7MNANCNFSM5M6K5MNQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@Gauravshah would you be happy to review it? :-) |
|
Hello, ... a quick turnaround on this would be very welcomed! Thanks, Phil. |
Gauravshah
requested changes
Feb 15, 2022
|
Good morning, Is there a status update? Are there plans to release a 0.0.6? |
geryepes
force-pushed
the
fix_support_grafana_8.3.x
branch
from
14b64a6 to
ef6ba7b
Compare
Gauravshah
approved these changes
Feb 16, 2022
Sure, will validate and merge |
|
@Gauravshah / @ShilpaSivanesan sorry to bump you guys. But can this please be merged, so we can use this great plugin with grafana 8.4.0 👍 |
|
Good morning, Is there a status update? Are there plans to release a 0.0.6? |
|
Thanks for your contribution @geryepes . Really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changes related to this PR
grafana/grafana@7319efe