Add tags option #94
Merged
Add tags option #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* IssueService subclasses return generators (rather than lists)
* Issue subclasses exist
* Encapsulating full foreign records, and logic for transforming
records into taskwarrior's format is deferred to those classes.
* Transform into taskwarrior's format via a `to_taskwarrior` method.
* Support dictionary operations and operators to minimize changes
to related APIs.
* Define UDAs specific to the underlying API.
* Define a unique key referencing a combination of any taskwarrior
record attributes (including UDAs) for deduplicating records and
associating said records with the underlying API.
* Issue subclasses define UDAs used by the foreign API.
* Issue subclasses define a foreign API key used for relating this
unique issue with
* Multiprocessing has been altered to receive new issues via a queue.
…ingle failure. * Required switching sentinel values to integers -- since the objects are pickled when being pushed onto the queue, the value popped off of the queue will *not* be the same object. Sad. * When any single service fails, abort processing for all to avoid marking tasks handled by failed services as 'done'.
.json is a bound method. Calling it is not safe during error handling.
…that are not completed; move managed task gathering into a separate function.
…g non-ascii characters.
…added to all incoming issues of this type.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Don't merge this until you have merged #93 please (it should clear up the PR diff automatically once you've merged).
add_tagsservice property that will automatically add specified tasks.Additional changes:
utf-8bytes (to allow one to specify tags having unicode characters)._get_taskwarrior_recordmethod well enough to make it public.