Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MSRV to 1.52 #2805

Merged
merged 2 commits into from
May 26, 2022
Merged

update MSRV to 1.52 #2805

merged 2 commits into from
May 26, 2022

Conversation

djmitche
Copy link
Collaborator

Description

This updates the minumum Rust version to 1.51, which is required by some updated dependencies. Since nothing depends on these Rust libraries yet, there's no reason not to bump it as necessary

@djmitche djmitche linked an issue May 22, 2022 that may be closed by this pull request
@djmitche
Copy link
Collaborator Author

Hm, 1.51 still failed. I don't know a reliable way to determine stabilization versions for a lint. So, guess-and-check :)

@djmitche djmitche changed the title update MSRV to 1.51 update MSRV to 1.52 May 22, 2022
@djmitche
Copy link
Collaborator Author

Yay! (Let's squash this when merging)

@tbabej tbabej merged commit e2ef45a into GothenburgBitFactory:develop May 26, 2022
@dbr
Copy link
Contributor

dbr commented May 26, 2022

I don't know a reliable way to determine stabilization versions for a lint

The "note: see issue #71668 rust-lang/rust#71668 for more information" part usually links to a tracking issue, which usually has a link to the stablization issue, which in this case is
rust-lang/rust#79208
which is usually linked to a milestone for the relevant release (in this case 1.52)
..but as evidenced by using the word "usually" three times, isn't exactly reliable and the relevant stablization issues can be pretty hard to find sometimes

Haven't tried it but there is https://github.com/foresterre/cargo-msrv - which appears to basically be build-each-version-bisection-till-it-works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MSRV to one that supports newer rusqlite, cbindgen
3 participants