Add a C++ wrapper around TC FFI #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I may need some help getting this to build everywhere... I suspect that none of these builders have Rust!) |
|
I can definitely figure out how to fix the rust tests, and I'll take a swing at the regular tests too. |
djmitche
force-pushed
the
wrap-tc
branch
5 times, most recently
from
a99408e to
a5b25af
Compare
|
Hm, I'll poke at that windows error. It's always windows. |
|
OK, that's better! I have also renamed |
|
@tbabej I'll rebase this, but -- any chance you could have a look soon? It is sort of blocking next-steps :) |
|
Looks like I made the rebasing of this one worse today, I'll take a swing at it. |
This uses CMake to build a simple Rust library (in `src/tc/rust`) that just re-exports everything from the `taskchampion-lib` crate. The C++ wrappers then wrap this into C++ objects with proper lifecycle maintenance, in the `tc` namespace. The C++ wrappers are incomplete, and missing methods are tagged with "TODO". These will be added as needed.
This allows Cargo to handle the linking peculiarities of platforms.
tbabej
reviewed
Jul 24, 2022
tbabej
reviewed
Jul 24, 2022
|
Looks all green, but your review is just a comment -- will you be looking again? |
tbabej
approved these changes
Jul 30, 2022
|
Awesome, I'm excited to hear it worked from Python too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses CMake to build a simple Rust library (in
src/tc/rust) that just re-exports everything from thetaskchampion-libcrate. The C++ wrappers then wrap this into C++ objects with proper lifecycle maintenance, in thetcnamespace. More details are in the included docs.The C++ wrappers are incomplete, and missing methods are tagged with "TODO". These will be added as needed.
Refs #2770.