-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DataSources to project json storage #6160
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ef90f51
feat: add DataSources project json storage
danstarns 0350016
Merge branch 'dev' into feat/datasource-storage
danstarns 0fb06c1
Merge branch 'dev' into feat/datasource-storage
danstarns e9bd6d5
Merge branch 'feat/datasource-storage' of github.com:GrapesJS/grapesj…
danstarns d35f56f
refactor: flip to stroage by default with skipFromStorage
danstarns dbd660d
refactor: change datasources storage to be an array
danstarns 4c8e4a5
docs: *
danstarns 71f2cbf
refactor: remove custom load
danstarns e0b467e
Allow to clear data sources
artf 987363c
Update serialization.ts
artf e7c3c9d
Update tests
artf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
packages/core/test/specs/data_sources/__snapshots__/storage.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`DataSource Storage .getProjectData ComponentDataVariable 1`] = ` | ||
{ | ||
"assets": [], | ||
"dataSources": [ | ||
{ | ||
"id": "data-variable-id", | ||
"records": [ | ||
{ | ||
"content": "Hello World", | ||
"id": "data-variable-id", | ||
}, | ||
], | ||
}, | ||
], | ||
"pages": [ | ||
{ | ||
"frames": [ | ||
{ | ||
"component": { | ||
"components": [ | ||
{ | ||
"components": [ | ||
{ | ||
"defaultValue": "default", | ||
"path": "component-storage.id1.content", | ||
"type": "data-variable", | ||
}, | ||
], | ||
"tagName": "h1", | ||
"type": "text", | ||
}, | ||
], | ||
"docEl": { | ||
"tagName": "html", | ||
}, | ||
"head": { | ||
"type": "head", | ||
}, | ||
"stylable": [ | ||
"background", | ||
"background-color", | ||
"background-image", | ||
"background-repeat", | ||
"background-attachment", | ||
"background-position", | ||
"background-size", | ||
], | ||
"type": "wrapper", | ||
}, | ||
"id": "data-variable-id", | ||
}, | ||
], | ||
"id": "data-variable-id", | ||
"type": "main", | ||
}, | ||
], | ||
"styles": [], | ||
"symbols": [], | ||
} | ||
`; | ||
|
||
exports[`DataSource Storage .loadProjectData ComponentDataVariable 1`] = ` | ||
{ | ||
"assets": [], | ||
"dataSources": [ | ||
{ | ||
"id": "data-variable-id", | ||
"records": [ | ||
{ | ||
"content": "Hello World Updated", | ||
"id": "data-variable-id", | ||
}, | ||
], | ||
}, | ||
], | ||
"pages": [ | ||
{ | ||
"frames": [ | ||
{ | ||
"component": { | ||
"components": [ | ||
{ | ||
"components": [ | ||
{ | ||
"defaultValue": "default", | ||
"path": "component-storage.id1.content", | ||
"type": "data-variable", | ||
}, | ||
], | ||
"tagName": "h1", | ||
"type": "text", | ||
}, | ||
], | ||
"docEl": { | ||
"tagName": "html", | ||
}, | ||
"head": { | ||
"type": "head", | ||
}, | ||
"stylable": [ | ||
"background", | ||
"background-color", | ||
"background-image", | ||
"background-repeat", | ||
"background-attachment", | ||
"background-position", | ||
"background-size", | ||
], | ||
"type": "wrapper", | ||
}, | ||
"id": "data-variable-id", | ||
}, | ||
], | ||
"id": "data-variable-id", | ||
"type": "main", | ||
}, | ||
], | ||
"styles": [], | ||
"symbols": [], | ||
} | ||
`; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be updated