A few fixes/improvements for the DataSource module #6219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
commented
Oct 15, 2024
Comment on lines
+181
to
+184
| postLoad() { | ||
| const { em, all } = this; | ||
| em.listenTo(all, collectionEvents, (m, c, o) => em.changesUp(o || c)); | ||
| } |
There was a problem hiding this comment.
trigger editor update on data source collection changes
| @@ -74,6 +74,7 @@ export default class DataSource extends Model<DataSourceProps> { | |||
| } | |||
|
|
|||
| this.listenTo(this.records, 'add', this.onAdd); | |||
| this.listenTo(this.records, collectionEvents, this.handleChanges); | |||
There was a problem hiding this comment.
Trigger editor updates on data record collection changes.
I think some data sources (eg. with data loaded asynchronously) could be updated without triggering any update.
| @@ -151,22 +151,11 @@ export default class StyleableModel<T extends ObjectHash = any> extends Model<T> | |||
| model: this, | |||
| em: this.em!, | |||
| dataVariable: dataVar, | |||
| updateValueFromDataVariable: (newValue: string) => this.updateStyleProp(styleProp, newValue), | |||
| updateValueFromDataVariable: () => this.updateView(), | |||
There was a problem hiding this comment.
no need to update the model as it's already resolved inside getStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.